[PATCH] D133198: [SCCP] convert signed div/rem to unsigned for non-negative operands

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 10:53:48 PDT 2022


spatel added inline comments.


================
Comment at: llvm/test/Transforms/SCCP/divrem.ll:141
 
+; negative test
+
----------------
BaoshanPang wrote:
> Should we add a 'TODO' here just like what we do for @sdiv_nonneg0_nonnegconst1 ?
This one is not safe to transform - it needs 'nsw':
https://alive2.llvm.org/ce/z/VDuSrw

I can make that explicit in the comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133198/new/

https://reviews.llvm.org/D133198



More information about the llvm-commits mailing list