[PATCH] D133150: [llvm-exegesis] Cross compile all enabled targets

Fri Sep 2 07:55:40 PDT 2022

courbet added inline comments.

================
Comment at: llvm/tools/llvm-exegesis/llvm-exegesis.cpp:301

-  InitializeNativeTarget();
-  InitializeNativeTargetAsmPrinter();
-  InitializeNativeTargetAsmParser();
+  InitializeAllTargets();
+  InitializeAllTargetMCs();
----------------
reames wrote:
> courbet wrote:
> > I think building all targets makes sens so that you can run an `llvm-exegesis` compiled on (say) X86  on AArch64. However at runtime we should only need to initialize the native target as we're going to jit compile and execute only for the host anyway.
> My eventual goal for this is to be able to exercise the jitting part in a cross compilation environment.  So, initializing all targets will be necessary.  
> 
> For this particular patch, I need the All variants to check linkage.  Without them, you can skip compiling a target specific library and not notice.  If you really want, I can remove them and do just the compile step in this patch, but I don't really see why.  
I see, SG.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133150/new/

https://reviews.llvm.org/D133150