[PATCH] D133203: [TypePromotionPass] Don't treat phi's as ToPromote

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 07:26:49 PDT 2022


dmgreen added a comment.

The goal was to fix llvm/test/CodeGen/AArch64/typepromotion-cost.ll (or a larger version of it), where there is no loop here but I believe the larger version is part of a larger loop. The point is that PhiNodes should not be considered "ToPromote" in the current cost calculation. They don't benefit from being promoted on their own - it is the uses of them that benefit.

The atomic loops are only expected to be executed once most of the time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133203/new/

https://reviews.llvm.org/D133203



More information about the llvm-commits mailing list