[PATCH] D133203: [TypePromotionPass] Don't treat phi's as ToPromote

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 2 06:59:08 PDT 2022


samparker added a comment.

It's not clear to me, from the tests, why a phi shouldn't be considered profitable... having `cmp w*, w*, uxt*` in those atomic loops look slower to me. Maybe we should be checking whether the phi is in a loop or not?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133203/new/

https://reviews.llvm.org/D133203



More information about the llvm-commits mailing list