[PATCH] D133193: [GlobalOpt] Fix debug variance problem in hasOnlyColdCalls

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM

> However, without debuginfo, GlobalOpt went further and ran

BlockFrequencyAnalysis and (more importanly) LoopAnalysis, and later on in
the pipeline, instcombine behaved in different ways when LoopInfo was
present.

We should really stop doing that, and instead pass in an argument whether InstCombine in a given pipeline position should use LoopInfo or not. Especially with the NewPM "if available" dependencies are a really bad idea, because whether a given analysis is available or not can be quite unpredictable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133193/new/

https://reviews.llvm.org/D133193