[PATCH] D133193: [GlobalOpt] Fix debug variance problem in hasOnlyColdCalls

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/GlobalOpt.cpp:1828
+        // code dependent on the presence of debug info.
         if (CalledFn->getIntrinsicID() != Intrinsic::not_intrinsic)
           continue;
----------------
These checks were originally added in
 https://reviews.llvm.org/D38413
but I suspect that checking if we're dealing with an intrinsic _after_ bailing out (with return false) on non-local linkage actually made the intrinsic check pointless.

So by changing the order I try to restore what I *think* was the purpose of the intrinsic check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133193/new/

https://reviews.llvm.org/D133193