[PATCH] D132633: [LoongArch] Add more fixups and relocations

[Ray Wang via Phabricator via llvm-commits]

wangleiat added inline comments.


================
Comment at: llvm/lib/Target/LoongArch/AsmParser/LoongArchAsmParser.cpp:191
+    return IsConstantImm
+               ? (isUInt<12>(Imm) && IsValidKind)
+               : (LoongArchAsmParser::classifySymbolRef(getImm(), VK) &&
----------------
MaskRay wrote:
> The common style doesn't add parentheses in the rhs of assignments or in `? :`
> The common style doesn't add parentheses in the rhs of assignments or in `? :`

Thanks.


================
Comment at: llvm/lib/Target/LoongArch/AsmParser/LoongArchAsmParser.cpp:198
   bool isUImm15() const { return isUImm<15>(); }
+  bool isSImm12() const { return isSImm<12>(); }
 
----------------
MaskRay wrote:
> place 12 before 14
> place 12 before 14

Thanks, i will reorder them.
sort( (signed)Max(`Shifted{U}Int<N, S>`))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132633/new/

https://reviews.llvm.org/D132633