[PATCH] D132633: [LoongArch] Add more fixups and relocations

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/lib/Target/LoongArch/AsmParser/LoongArchAsmParser.cpp:191
+    return IsConstantImm
+               ? (isUInt<12>(Imm) && IsValidKind)
+               : (LoongArchAsmParser::classifySymbolRef(getImm(), VK) &&
----------------
The common style doesn't add parentheses in the rhs of assignments or in `? :`


================
Comment at: llvm/lib/Target/LoongArch/AsmParser/LoongArchAsmParser.cpp:198
   bool isUImm15() const { return isUImm<15>(); }
+  bool isSImm12() const { return isSImm<12>(); }
 
----------------
place 12 before 14


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132633/new/

https://reviews.llvm.org/D132633