[PATCH] D128958: Add assembler plumbing for sanitize_memtag

[Mitch Phillips via Phabricator via llvm-commits]

hctim marked an inline comment as done.
hctim added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:714
+  if (GV->hasSanitizerMetadata() && GV->isTagged()) {
+    assert(TM.getTargetTriple().getArch() == Triple::aarch64 &&
+           "Tagged symbols are only supported on aarch64.");
----------------
peter.smith wrote:
> For the moment is it worth extending the check to an Android OS, that could be going over the top though.
done, and moved from assert -> error.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128958/new/

https://reviews.llvm.org/D128958