[PATCH] D128958: Add assembler plumbing for sanitize_memtag

[Peter Smith via Phabricator via llvm-commits]

peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

One really small comment, that is only a suggestion. This looks good to me. I've set approved, but please give a bit of time to see if there are any objections.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:714
+  if (GV->hasSanitizerMetadata() && GV->isTagged()) {
+    assert(TM.getTargetTriple().getArch() == Triple::aarch64 &&
+           "Tagged symbols are only supported on aarch64.");
----------------
For the moment is it worth extending the check to an Android OS, that could be going over the top though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128958/new/

https://reviews.llvm.org/D128958