[PATCH] D132073: [CodeGen] Zero out only modified registers

Thu Sep 1 11:41:05 PDT 2022

nickdesaulniers added inline comments.

================
Comment at: llvm/test/CodeGen/X86/zero-call-used-regs.ll:13-25
+; I386-NEXT:    .cfi_def_cfa_offset 8
+; I386-NEXT:    pushl %ebx
+; I386-NEXT:    .cfi_def_cfa_offset 12
+; I386-NEXT:    pushl %edi
+; I386-NEXT:    .cfi_def_cfa_offset 16
+; I386-NEXT:    pushl %esi
+; I386-NEXT:    .cfi_def_cfa_offset 20
----------------
void wrote:
> void wrote:
> > nickdesaulniers wrote:
> > > consider adding the `nounwind` fn attr to your test functions to eliminate all these obnoxious/verbose CFI directives stemming from `-fasynchronous-unwind-tables`. That should help with readability of the tests significantly.
> > It didn't work. :-/
> > It didn't work. :-/
> 
> It was `uwtable`. I removed it.
ah, I'll keep an eye out for that fn attr in the future, too. Thanks for pinpointing it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132073/new/

https://reviews.llvm.org/D132073