[PATCH] D132073: [CodeGen] Zero out only modified registers

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/test/CodeGen/X86/zero-call-used-regs.ll:7
 
-define dso_local i32 @skip(i32 returned %x) local_unnamed_addr #0 "zero-call-used-regs"="skip" {
 ; I386-LABEL: skip:
----------------
I like that the existing test cases are concise; it makes it easier to understand the behavior for the many different values of `zero-call-used-regs`.

Rather than update all of the existing tests, would you mind adding your new test case as a new test fn to the file? I suspect since this is affecting the kernel, we'd only need to test `used-gpr`?

That should significantly reduce the diffstat to this test file to help reviewers better understand the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132073/new/

https://reviews.llvm.org/D132073