[PATCH] D133078: [X86][NFC] Refine load/store reg to StackSlot for extensibility

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 19:20:09 PDT 2022


xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:3615
+         X86::FR16XRegClass.hasSubClassEq(RC))
+      return getLoadStoreOpcodeForFP16s(load, STI);
     llvm_unreachable("Unknown 4-byte regclass");
----------------
pengfei wrote:
> I think we don't need an extra function. Just like line 3591-3598.
That is just for future extension.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133078/new/

https://reviews.llvm.org/D133078



More information about the llvm-commits mailing list