[PATCH] D133037: [lld][WebAssemby] Allow import names and sections to be empty strings.

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

Did you mean to title this "Allow import names and modules to be empty strings."  ?

The change to the code here seems only to relate to the module and the not the name/field of the import, is that right?   Were fields already allowed to be empty?   In which case maybe the title should just be "Allow empty module names in imports?"

is the canonical ABI using empty fields or empty module names?  (presumably one can't use both .. otherwise everything is the same import :)



================
Comment at: lld/test/wasm/import-module-empty.ll:14
+
+attributes #0 = { "wasm-import-module"="" }
+
----------------
We've been in the process of trying to re-write all wasm-ld tests in assembly for a while now.   I think these should be easy enough to write in .s format?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133037/new/

https://reviews.llvm.org/D133037