[PATCH] D133040: [PGO] Support PGO annotation of CallBrInst

[Rong Xu via Phabricator via llvm-commits]

xur created this revision.
xur added a reviewer: davidxl.
Herald added subscribers: Enna1, wenlei, hiraditya.
Herald added a project: All.
xur requested review of this revision.
Herald added a project: LLVM.

We currently instrument CallBrInst but do not annotate it with the branch weight. This patch enables PGO annotation of CallBrInst.


https://reviews.llvm.org/D133040

Files:
  llvm/lib/Analysis/BranchProbabilityInfo.cpp
  llvm/lib/IR/Verifier.cpp
  llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
  llvm/test/Transforms/PGOProfile/Inputs/callbr.proftext
  llvm/test/Transforms/PGOProfile/callbr.ll


Index: llvm/test/Transforms/PGOProfile/callbr.ll
===================================================================
--- llvm/test/Transforms/PGOProfile/callbr.ll
+++ llvm/test/Transforms/PGOProfile/callbr.ll
@@ -1,4 +1,8 @@
 ; RUN: opt -passes=pgo-instr-gen -S 2>&1 < %s | FileCheck %s
+;
+; RUN: llvm-profdata merge %S/Inputs/callbr.proftext -o %t.profdata
+; RUN: opt < %s -passes=pgo-instr-use -pgo-test-profile-file=%t.profdata -S | FileCheck %s --check-prefix=USE
+
 
 define i32 @a() {
 entry:
@@ -15,3 +19,11 @@
   %0 = load i32, ptr %retval, align 4
   ret i32 %0
 }
+; USE-LABEL: @a
+; USE-SAME: !prof ![[BW_ENTRY:[0-9]+]]
+; USE: callbr void asm sideeffect
+; USE: to label
+; USE-SAME: !prof ![[BW_CALLBR:[0-9]+]]
+; USE ![[BW_ENTRY]] = !{!"function_entry_count", i64 100}
+; USE ![[BW_CALLBR]] = !{!"branch_weights", i32 80, i32 20}
+
Index: llvm/test/Transforms/PGOProfile/Inputs/callbr.proftext
===================================================================
--- /dev/null
+++ llvm/test/Transforms/PGOProfile/Inputs/callbr.proftext
@@ -0,0 +1,8 @@
+# :ir is the flag to indicate this is IR level profile.
+:ir
+a
+784007059655560962
+2
+100
+80
+
Index: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
===================================================================
--- llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
+++ llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
@@ -1398,7 +1398,8 @@
     if (TI->getNumSuccessors() < 2)
       continue;
     if (!(isa<BranchInst>(TI) || isa<SwitchInst>(TI) ||
-          isa<IndirectBrInst>(TI) || isa<InvokeInst>(TI)))
+          isa<IndirectBrInst>(TI) || isa<InvokeInst>(TI) ||
+          isa<CallBrInst>(TI)))
       continue;
 
     if (getBBInfo(&BB).CountValue == 0)
Index: llvm/lib/IR/Verifier.cpp
===================================================================
--- llvm/lib/IR/Verifier.cpp
+++ llvm/lib/IR/Verifier.cpp
@@ -4502,6 +4502,8 @@
         ExpectedNumOperands = IBI->getNumDestinations();
       else if (isa<SelectInst>(&I))
         ExpectedNumOperands = 2;
+      else if (CallBrInst *CI = dyn_cast<CallBrInst>(&I))
+        ExpectedNumOperands = CI->getNumSuccessors();
       else
         CheckFailed("!prof branch_weights are not allowed for this instruction",
                     MD);
Index: llvm/lib/Analysis/BranchProbabilityInfo.cpp
===================================================================
--- llvm/lib/Analysis/BranchProbabilityInfo.cpp
+++ llvm/lib/Analysis/BranchProbabilityInfo.cpp
@@ -380,7 +380,7 @@
   const Instruction *TI = BB->getTerminator();
   assert(TI->getNumSuccessors() > 1 && "expected more than one successor!");
   if (!(isa<BranchInst>(TI) || isa<SwitchInst>(TI) || isa<IndirectBrInst>(TI) ||
-        isa<InvokeInst>(TI)))
+        isa<InvokeInst>(TI) || isa<CallBrInst>(TI)))
     return false;
 
   MDNode *WeightsNode = TI->getMetadata(LLVMContext::MD_prof);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133040.457048.patch
Type: text/x-patch
Size: 2929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220831/5c0cf66d/attachment.bin>