[PATCH] D132957: [AMDGPU][MC][GFX11][NFC] Update tests for VOP3P.DPP instructions

[Joe Nash via Phabricator via llvm-commits]

Joe_Nash added a comment.

In D132957#3761978 <https://reviews.llvm.org/D132957#3761978>, @dp wrote:

>> When using DPP with VOP3P, OPSEL has to be set to all 0 and OPSEL_HI has to be set to all 1
>
> Does it mean that DPP variants of `fma_mix` opcodes are encoded incorrectly? Both llvm and SP3 assemblers do not set `op_sel_hi` to all 1:

It is true that there is no check verifying that desired property in the assembler. Filing an issue makes sense, though adding a check for the property seems low priority.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132957/new/

https://reviews.llvm.org/D132957