[PATCH] D132609: [llvm][test] precommit test for D130127

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: llvm/test/CodeGen/X86/tail-dup-asm-goto.ll:77
+; that we don't crash or run afoul of any MachineVerifier checks.
+; FIXME: enable -verify-machineinstrs for this test!
+define void @ceph_con_v2_try_read(i32 %__trans_tmp_3.sroa.0.0.copyload, i1 %tobool.not.i.i) nounwind {
----------------
nickdesaulniers wrote:
> nikic wrote:
> > This is going to break the expensive check build bots, so you might want to add an explicit `-verify-machineinstrs=0`.
> Done.  I've heard about "expensive checks" but don't know much about them. Is that a cmake config? Does it run machine verification explicitly?
Yes, this is the LLVM_ENABLE_EXPENSIVE_CHECKS cmake option. It mostly enables various verifiers (including verify-machineinstrs) that are not otherwise enabled by default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132609/new/

https://reviews.llvm.org/D132609