[PATCH] D132609: [llvm][test] precommit test for D130127

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 09:58:22 PDT 2022


nickdesaulniers added inline comments.


================
Comment at: llvm/test/CodeGen/X86/tail-dup-asm-goto.ll:77
+; that we don't crash or run afoul of any MachineVerifier checks.
+; FIXME: enable -verify-machineinstrs for this test!
+define void @ceph_con_v2_try_read(i32 %__trans_tmp_3.sroa.0.0.copyload, i1 %tobool.not.i.i) nounwind {
----------------
nikic wrote:
> This is going to break the expensive check build bots, so you might want to add an explicit `-verify-machineinstrs=0`.
Done.  I've heard about "expensive checks" but don't know much about them. Is that a cmake config? Does it run machine verification explicitly?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132609/new/

https://reviews.llvm.org/D132609



More information about the llvm-commits mailing list