[PATCH] D133028: [amdgpu] Always, instead of mostly, remove unused LDS symbols
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 31 10:31:56 PDT 2022
rampitec added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:249
+ for (auto &GV : make_early_inc_range(M.globals())) {
+ if (AMDGPU::isLDSVariableToLower(GV)) {
+ if (GV.use_empty()) {
----------------
It can be a single if and no braces around eraseFromParent. A little more readable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133028/new/
https://reviews.llvm.org/D133028
More information about the llvm-commits
mailing list