[PATCH] D133018: [RISCV] Support CSRs of AIA ext
Shao-Ce SUN via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 31 07:14:25 PDT 2022
sunshaoce added a comment.
In D133018#3761087 <https://reviews.llvm.org/D133018#3761087>, @jrtc27 wrote:
> Initial comment is your naming seems to be inconsistent with what's already in the file (and you can't even decide on Foo-Level vs Foo-level vs Foo Level); the current naming, taking from the ISA manual, does not use "level" anywhere, it's just "Machine Trap Handling" etc. Presumably these CSRs are currently defined in the evolving AIA spec and so aren't properly categorised with uniform names?
Thanks for your review. I'll update the revision when the spec are ratified.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133018/new/
https://reviews.llvm.org/D133018
More information about the llvm-commits
mailing list