[PATCH] D133018: [RISCV] Support CSRs of AIA ext

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 06:59:41 PDT 2022


jrtc27 added a comment.

Initial comment is your naming seems to be inconsistent with what's already in the file (and you can't even decide on Foo-Level vs Foo-level vs Foo Level); the current naming, taking from the ISA manual, does not use "level" anywhere, it's just "Machine Trap Handling" etc. Presumably these CSRs are currently defined in the evolving AIA spec and so aren't properly categorised with uniform names?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133018/new/

https://reviews.llvm.org/D133018



More information about the llvm-commits mailing list