[PATCH] D131959: [AMDGPU] Fix SDST operand of V_DIV_SCALE to always be VCC

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/constant-bus-restriction.ll:255
+;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
+; GFX10: {{.*}}
+; GFX11: {{.*}}
----------------
What is this and why is it needed?


================
Comment at: llvm/test/MC/AMDGPU/wave32.s:386
 
-v_div_scale_f32 v2, s2, v0, v0, v2
-// GFX1032: v_div_scale_f32 v2, s2, v0, v0, v2 ; encoding: [0x02,0x02,0x6d,0xd5,0x00,0x01,0x0a,0x04]
-// GFX1064-ERR: :[[@LINE-2]]:21: error: invalid operand for instruction
+v_div_scale_f32 v2, vcc, v0, v0, v2
+// GFX1032-ERR: :[[@LINE-1]]:1: error: operands are not valid for this GPU or mode
----------------
Pierre-vh wrote:
> rampitec wrote:
> > Please keep checks order so it is easy to see changes.
> I didn't change the order. Do you mean the -ERR check should always be at the bottom? (e.g. change GFX1064 to GFX1032 instead of adding the -ERR suffix & checking the error message)
It was wave32 test. Now it is wave64 test and wave32 test is below. They are swapped.


================
Comment at: llvm/test/tools/llvm-mca/AMDGPU/gfx11-double.s:147
 # CHECK-NEXT: [0,8]     .    .    .    .    .    .    .    .    DeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeE.   v_fract_f64_e32 v[4:5], v[4:5]
+# CHECK-NEXT: Truncated display due to cycle limit
 
----------------
foad wrote:
> Pierre-vh wrote:
> > Not sure why this popped up, I don't really understand the message
> Add `--timeline-max-cycles=0` to the RUN line? All the other files in this directory have it.
Why did it change at all?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131959/new/

https://reviews.llvm.org/D131959