[PATCH] D132706: [Symbolizer] Handle {{{bt}}} symbolizer markup element.

[Roland McGrath via Phabricator via llvm-commits]

mcgrathr added inline comments.


================
Comment at: llvm/test/DebugInfo/symbolize-filter-markup-bt.test:13
+CHECK: [[BEGIN:\[{3}]]ELF module #0x0 "a.o"; BuildID=abcdef [0x10-0x10f](r)[[END:\]{3}]]
+CHECK:    #0.0  0x0000000000000018 second /tmp[[SEP:[/\\]]]tmp.c:8:3 (a.o+0x8)
+CHECK:    #0.1  0x0000000000000018 first /tmp[[SEP]]tmp.c:4:3 (a.o+0x8)
----------------
peter.smith wrote:
> If there is a good place, could be worth an entry in the SymbolizerMarkupFormat or somewhere in the documentation explaining what the X.Y format is. IIUC we'd expect it when there are inlined function(s).
The markup format does not specify what human-readable output looks like.
Symbolization of backtraces including "virtual frames" for inlined functions is a QoI question for a particular symbolizing filter and how those are presented is a UI question for a particular presentation style.

I think it makes sense for the llvm-symbolizer documentation to describe its output formats, but that should not be conflated with the specification of the markup format.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132706/new/

https://reviews.llvm.org/D132706