[PATCH] D132706: [Symbolizer] Handle {{{bt}}} symbolizer markup element.

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

Do you need to update the docs/SymbolizerMarkupFormat.rst to say that backtrace is now implemented?

Code changes look good to me.



================
Comment at: llvm/test/DebugInfo/symbolize-filter-markup-bt.test:13
+CHECK: [[BEGIN:\[{3}]]ELF module #0x0 "a.o"; BuildID=abcdef [0x10-0x10f](r)[[END:\]{3}]]
+CHECK:    #0.0  0x0000000000000018 second /tmp[[SEP:[/\\]]]tmp.c:8:3 (a.o+0x8)
+CHECK:    #0.1  0x0000000000000018 first /tmp[[SEP]]tmp.c:4:3 (a.o+0x8)
----------------
If there is a good place, could be worth an entry in the SymbolizerMarkupFormat or somewhere in the documentation explaining what the X.Y format is. IIUC we'd expect it when there are inlined function(s).


================
Comment at: llvm/test/DebugInfo/symbolize-filter-markup-bt.test:60
+	.loc	1 8 3 prologue_end              # tmp.c:8:3
+	callq	first
+.Ltmp1:
----------------
If I've interpreted this right, there was some function called second, that probably just called first() so it has been inlined here? Only mention of second that I could find was as an inline function.

May be worth a comment as it could help explain the backtrace.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132706/new/

https://reviews.llvm.org/D132706