[PATCH] D132883: [cmake] Don't include symlinks to tools in Build-all when `LLVM_BUILD_TOOLS` is off

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 04:29:34 PDT 2022


smeenai added a comment.

Could we just read the `EXCLUDE_FROM_ALL` property of the target tool and use that to set the same property on the symlink target? We'd ideally use a generator expression for that so it works independently of the order the tool target and the symlink target are defined, but the CMake documentation makes it seem like `EXCLUDE_FROM_ALL` may only support generator expressions in 3.19 and above, whereas our minimum is 3.13.4. It's pretty conventional to always define the symlink target after the tool target though, so even just setting the property directly should work fine in practice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132883/new/

https://reviews.llvm.org/D132883



More information about the llvm-commits mailing list