[PATCH] D132883: [cmake] Don't include symlinks to tools in Build-all when `LLVM_BUILD_TOOLS` is off

[Markus Böck via Phabricator via llvm-commits]

zero9178 added a comment.

In D132883#3756539 <https://reviews.llvm.org/D132883#3756539>, @Ericson2314 wrote:

> I need to review more but I am suspicious of this exact fix before we are looking up a LLVM-specific env inside what I think is a reusable project also useable by downstream projects.

The code below sort of already makes this assumption, but I could change this patch and the line below to use `${project}_BUILD_TOOLS`. That "enforces" common vocabulary while also respecting any other downstream projects making use of `llvm_add_tool_symlink`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132883/new/

https://reviews.llvm.org/D132883