[PATCH] D128302: [AArch64][CostModel] Detects that ExtractElement / InsertElement are not free in AArch64 with integer types.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 09:23:16 PDT 2022


davidxl added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.h:68
+  InstructionCost getVectorInstrCostHelper(Type *Val, unsigned Index,
+                                           bool VirtualInst);
+
----------------
Maybe changing 'VirtualInst' to be name 'hasNoRealUse' or flip it to 'hasRealUse'?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128302/new/

https://reviews.llvm.org/D128302



More information about the llvm-commits mailing list