[PATCH] D124439: [JumpThreading][NFC][CompileTime] Do not recompute BPI/BFI analyzes

Thu Aug 25 06:13:10 PDT 2022

ebrevnov added a comment.

In D124439#3731473 <https://reviews.llvm.org/D124439#3731473>, @ebrevnov wrote:

> In D124439#3483470 <https://reviews.llvm.org/D124439#3483470>, @jyknight wrote:
>
>> This change has caused our internal PGO+NewPM builds of clang to have become non-reproducible (that is: the binary is different every build, when built with a Clang that includes this change). The problem appears only when providing profile data. I am not sure //why// this change causes a problem -- perhaps some of the analysis data ought to have been invalidated by some other pass, but wasn't?
>>
>> But, I've bisected to exactly this commit, so, I'm going to revert it while continuing to investigate.
>
> Hi! Any update on this?
>
> Not sure if it has any impact on your case but there is a chance that JumpThreading updates profile metadata through updatePredecessorProfileMetadata and doesn't invalidate BPI/BFI analysis.

@jyknight, ping

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124439/new/

https://reviews.llvm.org/D124439