[PATCH] D132482: RISCV: permit unaligned nop-slide padding emission

Tue Aug 23 14:27:51 PDT 2022

compnerd added a comment.

In D132482#3743723 <https://reviews.llvm.org/D132482#3743723>, @luismarques wrote:

> Can you add a comment documenting the binutils behaviour (where the zeroes, c.nop, full nop go, etc.) and indicating that we implement the same?

Sure, I can do that.

> Don't forget to include the full context in your patches. It seems like this is going in the right direction with the great feedback from @jrtc27.

> Yeah, it's just annoying to do since I'm working on a remote machine.

>> The test case may seem to be under-reduced due to the use of LLVM IR
>> rather than assembly for the input, however, I was unable to reproduce
>> the failure when using the assembly input.
>
> Do the other targets have any MC assembly test for this? I guess you can easily check that by modifying their hook and checking the list of breaking MC tests.

I'm not sure, but the test case was reduced to what it should be thanks to @jrtc27's help.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132482/new/

https://reviews.llvm.org/D132482