[PATCH] D132482: RISCV: permit unaligned nop-slide padding emission

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 14:21:52 PDT 2022


luismarques added a comment.

Can you add a comment documenting the binutils behaviour (where the zeroes, c.nop, full nop go, etc.) and indicating that we implement the same?

Don't forget to include the full context in your patches. It seems like this is going in the right direction with the great feedback from @jrtc27.

> The test case may seem to be under-reduced due to the use of LLVM IR
> rather than assembly for the input, however, I was unable to reproduce
> the failure when using the assembly input.

Do the other targets have any MC assembly test for this? I guess you can easily check that by modifying their hook and checking the list of breaking MC tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132482/new/

https://reviews.llvm.org/D132482



More information about the llvm-commits mailing list