[PATCH] D131914: [ubsan-minimal] Report the address of an error

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 14:09:59 PDT 2022


ikudrin updated this revision to Diff 454957.
ikudrin marked 4 inline comments as done.
ikudrin edited the summary of this revision.
ikudrin added a comment.

Thanks for the review!

- An NFC part is committed as https://reviews.llvm.org/rG1959a55591da
- Print leading zeroes,
- "@..." -> "by 0x...",
- Update tests, except `recover-dedup-limit.cpp`, because that change would only add some noise and not any value to it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131914/new/

https://reviews.llvm.org/D131914

Files:
  compiler-rt/lib/ubsan_minimal/ubsan_minimal_handlers.cpp
  compiler-rt/test/ubsan_minimal/TestCases/alignment-assumption.c
  compiler-rt/test/ubsan_minimal/TestCases/implicit-integer-sign-change.c
  compiler-rt/test/ubsan_minimal/TestCases/implicit-signed-integer-truncation-or-sign-change.c
  compiler-rt/test/ubsan_minimal/TestCases/implicit-signed-integer-truncation.c
  compiler-rt/test/ubsan_minimal/TestCases/implicit-unsigned-integer-truncation.c
  compiler-rt/test/ubsan_minimal/TestCases/nullptr-and-nonzero-offset.c
  compiler-rt/test/ubsan_minimal/TestCases/recover-dedup.cpp
  compiler-rt/test/ubsan_minimal/TestCases/uadd-overflow.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131914.454957.patch
Type: text/x-patch
Size: 7375 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220823/5f0be20d/attachment.bin>


More information about the llvm-commits mailing list