[PATCH] D131914: [ubsan-minimal] Report the address of an error

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/ubsan_minimal/ubsan_minimal_handlers.cpp:105
+static const unsigned int kMaxAddrBuf = SANITIZER_WORDSIZE / 4;
+#define MSG_TMPL(msg) "ubsan: " msg " @"
+#define MSG_TMPL_END(buf, msg) (buf + sizeof(MSG_TMPL(msg)) - 1)
----------------
vitalybuka wrote:
> Can we have "@" -> "at 0x"?
> Can we have "@" -> "at 0x"?

Looks like we mostly use "at" for load/store location
maybe "@" -> "by 0x", then it would be clear that this is the code


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131914/new/

https://reviews.llvm.org/D131914