[PATCH] D132482: RISCV: permit unaligned nop-slide padding emission
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 23 13:00:05 PDT 2022
jrtc27 added inline comments.
================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp:365
+ OS.write("\x01\0", 2);
+ Count -= 2;
+ }
----------------
I would suggest not reordering the nop and c.nop in this commit, it's not required. However, if you are going to do it, this is wrong, as if Count is a multiple of 4 this will emit a c.nop, decrease Count by 2 and then emit 1 fewer nop than required.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132482/new/
https://reviews.llvm.org/D132482
More information about the llvm-commits
mailing list