[PATCH] D132390: [MCContext] reverse order of DebugPrefixMap sort

Dan McGregor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 09:19:57 PDT 2022


dankm added a comment.

In D132390#3742950 <https://reviews.llvm.org/D132390#3742950>, @dankm wrote:

> Sure it does. It's somewhat undocumented, and arguably a bug in its own right (I was torn when I implemented the original prefix mapping stuff), but it's a simple prefix substitution. `/t=/lu` turns `/tmp` into `/lump` happily.

Hmm. While this is true, it depends on how `replace_path_prefix` is called, and that seems inconsistent. That *is* a bug. Clang gives me multiple file names when I try that there. In llvm-mc, though it's always the string prefix.
I'll use subdirectories, since I now believe it *should* fail in the `/t=/lu` changing `/tmp` to `/lump`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132390/new/

https://reviews.llvm.org/D132390



More information about the llvm-commits mailing list