[PATCH] D132390: [MCContext] reverse order of DebugPrefixMap sort

Tue Aug 23 08:54:15 PDT 2022

dankm added a comment.

In D132390#3741646 <https://reviews.llvm.org/D132390#3741646>, @MaskRay wrote:

> The test doesn't help. `%t=...` does not match the path component `%t.foo`. A nested directory is needed to test the situation.

Sure it does. It's somewhat undocumented, and arguably a bug in its own right (I was torn when I implemented the original prefix mapping stuff), but it's a simple prefix substitution. `/t=/lu` turns `/tmp` into `/lump` happily.
In this case without the header change, that unit test turns the file path into `/broken_root.foo/src.s`.

> You probably want to swap the order of the two -fdebug-prefix-map= for -dwarf-version=5 to get some variance.

I like this suggestion. The order of the parameters, so let's ensure that both work.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132390/new/

https://reviews.llvm.org/D132390