[PATCH] D132482: RISCV: permit unaligned nop-slide padding emission

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 09:14:16 PDT 2022


jrtc27 added inline comments.


================
Comment at: llvm/test/MC/RISCV/nop-slide.ll:1
+; RUN: llc -mtriple riscv64-unknown-linux-gnu -filetype obj -o - %s | llvm-objdump -t - | FileCheck %s
+
----------------
Just riscv64, not Linux-specific


================
Comment at: llvm/test/MC/RISCV/nop-slide.ll:4
+target datalayout = "e-m:e-p:64:64-i64:64-i128:128-n64-S128"
+target triple = "riscv64-unknown-linux-gnu"
+
----------------
These should be redundant


================
Comment at: llvm/test/MC/RISCV/nop-slide.ll:7
+ at b = dso_local global i8 0, section ".init.data", align 1
+ at c= dso_local global ptr null, section ".init.data", align 8
+
----------------
How does this test it? There’s no code here to align?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132482/new/

https://reviews.llvm.org/D132482



More information about the llvm-commits mailing list