[PATCH] D132482: RISCV: permit unaligned nop-slide padding emission

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 09:12:34 PDT 2022


jrtc27 added a comment.

Should the zeroes not come first instead of last? Otherwise you’re all but guaranteed to have unaligned instructions. Not that you should execute them either way, but it may confuse disassemblers. What does binutils do?



================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp:366
+  // section (otherwise we have unaligned instructions, and thus have far
+  // bigger problems), so just write zeros instead.  This also may occur for
+  // non-standard data sections which are not declared and thus get detected as
----------------
IALIGN; C changes this from 4 to 2


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132482/new/

https://reviews.llvm.org/D132482



More information about the llvm-commits mailing list