[PATCH] D131931: [amdgpu] Change the RA to basic

LuoYuanke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 07:03:53 PDT 2022


LuoYuanke added a comment.

> No, this test does not fail - it has been passing for over two years. So what problem are you trying to fix? Are you testing some local changes that provoked a failure?

This case doesn't fail, but the similar case (as below) would fail in SILowerSGPRSpills pass. Replacing it with basic-ra has no side effect.

  define internal void @use256vgprs() {
    %v0 = call i32 asm sideeffect "; def $0", "=v"()
    %v1 = call i32 asm sideeffect "; def $0", "=v"()
    call void asm sideeffect "; use $0", "v"(i32 %v0)
    call void asm sideeffect "; use $0", "v"(i32 %v1)
    ret void
  }
  
  define amdgpu_kernel void @f256() #256 {
    call void @use256vgprs()
    ret void
  }
  attributes #256 = { nounwind "amdgpu-flat-work-group-size"="256,256" }
  
  define amdgpu_kernel void @f512() #512 {
    call void @foo()
    call void @use256vgprs()
    ret void
  }
  attributes #512 = { nounwind "amdgpu-flat-work-group-size"="512,512" }
  
  define amdgpu_kernel void @f1024() #1024 {
    call void @foo()
    call void @use256vgprs()
    ret void
  }
  
  attributes #1024 = { nounwind "amdgpu-flat-work-group-size"="1024,1024" }
  
  declare void @foo()




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131931/new/

https://reviews.llvm.org/D131931



More information about the llvm-commits mailing list