[PATCH] D131931: [amdgpu] Change the RA to basic

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

> Specifying -regalloc=fast is not reliable. With fast register allocation,
> LIS = getAnalysisIfAvailable<LiveIntervals>(); get nullptr
> in "si-lower-sgpr-spills" pass, so the slot index is not created in the
> pass for new inserted instructions.

That sounds like a bug in SILowerSGPRSpills. It claims to preserve all analyses, so it should be able to preserve SlotIndexex even if LiveIntervals is not available.

> When verifying the machine
> instruction, it fails on checking slot index.

No, this test does not fail - it has been passing for over two years. So what problem are you trying to fix? Are you testing some local changes that provoked a failure?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131931/new/

https://reviews.llvm.org/D131931