[PATCH] D118037: [DAGCombine] Consider SETULT as carry flag

Tue Aug 23 00:08:15 PDT 2022

chfast added a comment.

In D118037#3740763 <https://reviews.llvm.org/D118037#3740763>, @deadalnix wrote:

> In D118037#3731784 <https://reviews.llvm.org/D118037#3731784>, @RKSimon wrote:
>
>> Please can you rebase to see where we currently are? Also D127115 <https://reviews.llvm.org/D127115> affects these tests - so maybe see whether this SETULT change is still needed after that patch or whether something else can further improve the codegen?
>
> For what it is worth, when the dag is processed in fully topological order, and you add in D57317 <https://reviews.llvm.org/D57317> ,  then you get optimal codegen for these tests.

Yes, this is great. Thanks for reaching out. I will try to be little involved in both then.

I'm not actively working on this one so I will probably focus on regression tests for combining cmp into sbb (as the result of recent changes to InstCombine).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118037/new/

https://reviews.llvm.org/D118037