[PATCH] D118037: [DAGCombine] Consider SETULT as carry flag

Amaury SECHET via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 22 14:04:45 PDT 2022


deadalnix added a comment.

In D118037#3731784 <https://reviews.llvm.org/D118037#3731784>, @RKSimon wrote:

> Please can you rebase to see where we currently are? Also D127115 <https://reviews.llvm.org/D127115> affects these tests - so maybe see whether this SETULT change is still needed after that patch or whether something else can further improve the codegen?

For what it is worth, when the dag is processed in fully topological order, and you add in D57317 <https://reviews.llvm.org/D57317> ,  then you get optimal codegen for these tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118037/new/

https://reviews.llvm.org/D118037



More information about the llvm-commits mailing list