[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 16:34:01 PDT 2022


MaskRay added a comment.

Both D131638 <https://reviews.llvm.org/D131638> and this patch want to use classes with inheritance to support different compression algorithms.
There have been many versions but I think I have never received a convincing argument how such an inheritance based design looks better / is less error-prone than free functions (D130506 <https://reviews.llvm.org/D130506>).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131992/new/

https://reviews.llvm.org/D131992



More information about the llvm-commits mailing list