[PATCH] D131047: [AArch64] Change aarch64_neon_pmull{,64} intrinsic ISel through a new SDNode.

[Mingming Liu via Phabricator via llvm-commits]

mingmingl updated this revision to Diff 453798.
mingmingl added a comment.

Changes

1. Fix a subtle C++ bug in static lambda ` TryVectorizeOperand`-> the helper function is declared as lambda to limit scope (no need to sanity check parameters), but it should really not capture variables (that could change per invocation). This issue just occurred to me when looking at the codebase.
2. In tablegen pattern `SIMDDifferentThreeVectorBD`, remove default parameter (`null`) for `OpNode` since there isn't a use case for default parameter now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131047/new/

https://reviews.llvm.org/D131047

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.h
  llvm/lib/Target/AArch64/AArch64InstrFormats.td
  llvm/lib/Target/AArch64/AArch64InstrInfo.td
  llvm/test/CodeGen/AArch64/aarch64-pmull2.ll
  llvm/test/CodeGen/AArch64/pmull-ldr-merge.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131047.453798.patch
Type: text/x-patch
Size: 14361 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220818/40d09151/attachment.bin>