[PATCH] D126440: [RISCV] Return an invalid cost for memory ops with unsupported types

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 10:53:25 PDT 2022


reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

This patch does not meet basic standards.

- It has no explanation of intent.
- It has no tests.
- The code change itself seems nonsensical.

Phabricator doesn't give a way to hard reject, so marking as Request Changes and removing myself as reviewer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126440/new/

https://reviews.llvm.org/D126440



More information about the llvm-commits mailing list