[PATCH] D132122: AArch64 SVE: add sve patterns to make use of predicated smin, umin, smax, and umax instructions, add ll test file for the new patterns

[David Sherwood via Phabricator via llvm-commits]

david-arm added a comment.

Could you also add a brief description



================
Comment at: llvm/test/CodeGen/AArch64/sve-min-max-pred.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=aarch64-eabi %s -o - | FileCheck %s --check-prefixes=CHECK,CHECK-ISEL
+; RUN: llc -mtriple=aarch64-eabi -global-isel %s -o - | FileCheck %s --check-prefixes=CHECK,CHECK-GLOBAL
----------------
I think you only need one RUN line here and it should specify the SVE attribute, i.e. something like this:

; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve -o - | FileCheck %s



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132122/new/

https://reviews.llvm.org/D132122