[PATCH] D132107: [DAGCombiner][NFC] Remove extra brackets.
WangLian via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 18 00:40:14 PDT 2022
Jimerlife added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3723
// canonicalize (sub X, (vscale * C)) to (add X, (vscale * -C))
- if (N1.getOpcode() == ISD::VSCALE) {
+ if (N1.getOpcode() == ISD::VSCALE && N1.hasOneUse()) {
const APInt &IntVal = N1.getConstantOperandAPInt(0);
----------------
RKSimon wrote:
> this isn't nfc - handle it in a seperate patch, preferably with a test
OK, I removed this change. I will do it in next patch. Thanck you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132107/new/
https://reviews.llvm.org/D132107
More information about the llvm-commits
mailing list