[PATCH] D131931: [amdgpu] Change the RA to basic

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

In D131931#3727692 <https://reviews.llvm.org/D131931#3727692>, @LuoYuanke wrote:

> In D131931#3726692 <https://reviews.llvm.org/D131931#3726692>, @rampitec wrote:
>
>> Typo in description: "intruction".
>
> Fixed, thanks.
>
>> I also think spilling should be fixed to work with fast-ra instead.
>
> Fast-ra doesn't depened on `SlotIndexes` and `LiveIntervals`, but "si-lower-sgpr-spills" depend on `LiveIntervals`, so I am not sure we can fix. On the other hand basic-ra fit this case very well, it reduce the compiling time and depend on `SlotIndexes` and `LiveIntervals`. Even we use fast-ra the pass pipeline doesn't change much which means it fast-ra won't reduce the compiling time for other passes, it only reduce the compiling time of ra itself.

OK, using fast-ra is not a point of this test anyway, and that shall not be your problem to fix sgpr spilling even if we need it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131931/new/

https://reviews.llvm.org/D131931