[PATCH] D131931: [amdgpu] Change the RA to basic

LuoYuanke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 16 17:12:31 PDT 2022


LuoYuanke added a comment.

In D131931#3726692 <https://reviews.llvm.org/D131931#3726692>, @rampitec wrote:

> Typo in description: "intruction".

Fixed, thanks.

> I also think spilling should be fixed to work with fast-ra instead.

Fast-ra doesn't depened on `SlotIndexes` and `LiveIntervals`, but "si-lower-sgpr-spills" depend on `LiveIntervals`, so I am not sure we can fix. On the other hand basic-ra fit this case very well, it reduce the compiling time and depend on `SlotIndexes` and `LiveIntervals`. Even we use fast-ra the pass pipeline doesn't change much which means it fast-ra won't reduce the compiling time for other passes, it only reduce the compiling time of ra itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131931/new/

https://reviews.llvm.org/D131931



More information about the llvm-commits mailing list