[PATCH] D131356: [InstCombine] reassociate bitwise logic chains based on uses

[chenglin.bi via Phabricator via llvm-commits]

bcl5980 added a comment.

In D131356#3727010 <https://reviews.llvm.org/D131356#3727010>, @spatel wrote:

> In D131356#3726615 <https://reviews.llvm.org/D131356#3726615>, @bcl5980 wrote:
>
>> Maybe we can run ipsccp until no changed(Similar to Instcombine) to fix all these tickets. like:
>
> I'm not familiar with ipsccp, and I don't know what impact running that pass to fix-point would have on compile-time, but if that works, do you want to make a patch?
>
> It doesn't look like this patch would have any noticeable impact on compile-time:
> https://llvm-compile-time-tracker.com/index.php?config=NewPM-O3&stat=instructions&remote=rotateright

Sorry for the confusion comments. This patch is OK for me. It helps on the cases with non-bool types that ipsccp can't tough. Put them to reassociate pass could avoid the potential dead loop in instcombine, but for now reassociate pass still have the history code don't work for i1 types.
And I'm also trying to fix on ipsccp to eliminate all similar issues with i1 types.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131356/new/

https://reviews.llvm.org/D131356