[PATCH] D131356: [InstCombine] reassociate bitwise logic chains based on uses

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 16 12:40:25 PDT 2022


fhahn added a comment.

In D131356#3727010 <https://reviews.llvm.org/D131356#3727010>, @spatel wrote:

> In D131356#3726615 <https://reviews.llvm.org/D131356#3726615>, @bcl5980 wrote:
>
>> Maybe we can run ipsccp until no changed(Similar to Instcombine) to fix all these tickets. like:
>
> I'm not familiar with ipsccp, and I don't know what impact running that pass to fix-point would have on compile-time, but if that works, do you want to make a patch?

IPSCCP/SCCP should iterate until they reach a fixed-point already. If running `runIPSCCP(M, DL, GetTLI, getAnalysis)` multiple times improves the result, then there's likely a dependency missing in the solver.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131356/new/

https://reviews.llvm.org/D131356



More information about the llvm-commits mailing list